Remove unnecessary semicolons in source code #131
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
greole
reviewed
Jun 11, 2024
CHANGELOG.md
Outdated
| @@ -5,6 +5,7 @@ SPDX-License-Identifier: GPL-3.0-or-later | |||
| --> | |||
|
|
|||
| # 0.5.4 (unreleased) | |||
| - Remove unnecessary semicolon in source code [PR #131] (https://github.com/hpsim/OGL/pull/131) | |||
There was a problem hiding this comment.
Not needed to add to the changelog since it has no effect for the user.
Suggested change
| - Remove unnecessary semicolon in source code [PR #131] (https://github.com/hpsim/OGL/pull/131) |
There was a problem hiding this comment.
Okay, but it will fail the corresponding check.
There was a problem hiding this comment.
No worries, we can still merge. It is not a hard requirement. We could also add an optional flag for the changelog test.
|
@greole Do you think it is okay to merge? |
greole
force-pushed
the
remove-unnecessary-semicolon
branch
from
ab78ea5 to
8dcf522
Compare
greole
approved these changes
Jun 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.