Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add feeds favicon #181

Open
10 tasks
ai opened this issue Apr 27, 2024 · 0 comments
Open
10 tasks

Add feeds favicon #181

ai opened this issue Apr 27, 2024 · 0 comments
Labels

Comments

@ai
Copy link
Contributor

ai commented Apr 27, 2024

  • Add algorithm to find favicon. We can use good npm library or write our own.
    • We should load URL and check for icons
    • If the URL is not HTML we should load /
    • In HTML we should prefer type="image/svg+xml" rel="icon" (we should be ready that rel contains multiple words)
    • If not, we can use the first rel="icon"
    • If there is no icons, let’s check that /favicon.ico exists
  • In preview we need a favicon before user will add feed, so we need to adds favicons to $candidates (or create another store).
  • We need to add icon key to FeedValue
  • We need to detect and set icon in addFeed() (if feedValue.icon is not set already).
  • We need to be ready when icon will be updated. I suggest add updateFeedIcon(feedId) and create some <UiFeedIcon> component, which will call updateFeedIcon() on <img>.onerror.
@ai ai added the Core JS label Apr 27, 2024
@ai ai moved this to Ready to Take in Slow Reader Tasks Apr 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Status: Ready to Take
Development

No branches or pull requests

1 participant