Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chapter 11 further issues #71

Open
codeZeilen opened this issue Nov 2, 2020 · 3 comments
Open

Chapter 11 further issues #71

codeZeilen opened this issue Nov 2, 2020 · 3 comments

Comments

@codeZeilen
Copy link
Member

codeZeilen commented Nov 2, 2020

Unsolved from #67

S6. Exercises vs. only code descriptions

  • not really a problem but it feels kind of inconsistent
  • some provided code snippets come with a request to define / update etc. them oneself (identified by a squeak cat head before them). (E.g. Method 11.4) Others come with an description and saying how things can be done. (E.g. Method 11.5). I suppose the ones without an exercise aren't really necessary to follow the tutorial? But as this chapter feels like a - try every example - tutorial this for me personally just appeared a bit inconsistent.

S10. Not using accessor methods

  • In Method 11.29 instance variables are set directly and not via accessor methods, which especially for faces: and dieValue: is weird, because we define those methods later on (and they do sensible sanity checks)
@LinqLover
Copy link
Collaborator

  • S6: I think that additional \dothiss would unnecessarily bloat the book. IMO it follows from the context that the remaining methods should be added as well.
  • S10: Please see Morphic/DieMorph improvements #119.

@LinqLover
Copy link
Collaborator

@codeZeilen What is your opinion on the only last remaining item here, S6?

@LinqLover
Copy link
Collaborator

@codeZeilen Anything left to do here? :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants