Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

API exception handling makes homeassistant sad. #35

Open
garbled1 opened this issue Nov 27, 2021 · 1 comment
Open

API exception handling makes homeassistant sad. #35

garbled1 opened this issue Nov 27, 2021 · 1 comment

Comments

@garbled1
Copy link
Collaborator

See: home-assistant/core#60459

Basically, what the dev team told me was that this library, handling the exception via a broad exception handler, and then logging, passes the whole exception into the logs of HA. Suggestion was:

I’d pull out the broad except handlers and let it raise + add the response.raise_for_status() then handle it in Home Assistant

Not sure if this is something you'd be willing to tackle?

@hpeyerl
Copy link
Owner

hpeyerl commented Dec 2, 2021

Sorry for the lack of response. All I have to say at this point is "Patches welcome".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants