Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Cache VOL #17

Open
wants to merge 69 commits into
base: master
Choose a base branch
from
Open

Conversation

zhenghh04
Copy link
Collaborator

This allows h5bench to pause the async operations in Cache VOL and start them later after issuing out all the dataset write calls.

@zhenghh04 zhenghh04 requested review from jeanbez and sbyna August 26, 2021 21:15
@jeanbez jeanbez added the enhancement New feature or request label Sep 7, 2021
@jeanbez
Copy link
Member

jeanbez commented Oct 1, 2021

@zhenghh04 could you also add the documentation for this?

@sbyna
Copy link
Member

sbyna commented Nov 9, 2021

@zhenghh04 Could you please add / update documentation on how to use the benchmark with Cache VOL?

@sbyna sbyna requested a review from houjun December 14, 2021 19:12
@jeanbez jeanbez changed the title Added support for Cache VOL WIP: Added support for Cache VOL Jan 14, 2022
@jeanbez jeanbez changed the title WIP: Added support for Cache VOL Added support for Cache VOL May 2, 2022
@jeanbez
Copy link
Member

jeanbez commented May 2, 2022

@sbyna and @houjun if you have some time available, could you help us double-check this new feature?
@zhenghh04 I've included some additional test cases and checked the changes, it seems good to me.

@jeanbez jeanbez modified the milestones: v.1.3, v.1.4 Oct 7, 2022
zhenghh04 and others added 2 commits December 5, 2022 21:57
1) Added back "MODE" option in cfg file.
   By default if the user does not specify MODE in cfg file, it will check whether it has async vol connector. If so, it will set as ASYNC; otherwise it will set as SYNC. For Cache VOL, one has to explicitly set MODE: SYNC in cfg file.

2) Removed unnecessary MPI_Barrier
@zhenghh04
Copy link
Collaborator Author

@jeanbez @houjun I pushed a new commit:

I added back "MODE" option in cfg file for Cache VOL support. If the user does not set MODE in the cfg file, then it will be as it used to be: i.e., determined merely by whether async vol connector is used or not.

I also removed the barrier.

@jeanbez jeanbez modified the milestones: v.1.4, v.1.5 May 10, 2023
@jeanbez jeanbez added the HDF5 VOL Support for HDF5 VOL connectors label Jul 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request HDF5 VOL Support for HDF5 VOL connectors
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants