Bugg or not using it correctly??

[lgLindstrom]

Hi (again)

I am using your DynamicQueue_t class. Testing it in a separate environment ( no wifi, mqtt etc) it works correctly,

Using DynamicQueue_t in a more complex environment I have some problems. I dont know if it a bug in the class or if I am using it in the wring way.

This setup is like this.

Generator task generates mqtt messages that are pushed into the queue. I have removed how payload is generated but basically a counter is updated by 1 every loop. This seems to be working fine according to the log output.

static void GeneratorTask (void *data) {
            vTaskDelay(10 / portTICK_RATE_MS);
            int i=0;
            while(true){        
                while (! queue->full()) {
                    queue->send<mqtt_message_t>(mqtt_message_t {"testCounter",  <payload> } );
                    ESP_LOGW(TAG, "%s:%d topic: %s  payload: %s ",  __func__, __LINE__ , "testCounder", payload.c_str());
                    i++;
                    vTaskDelay(10 / portTICK_RATE_MS);
                };
            }

Then I have a publisher task reading the queu and publishing data to the Mqtt broker (raspberry pi) using ESP-MQTT client.

static void publishTask(void * bas) {
        mqtt_message_t message;
        while(true){
            vTaskDelay(10 / portTICK_RATE_MS);
            
         while ( ! queue->empty()  ) {
                esp_err_t result = queue->receive<mqtt_message_t>(message);
                if (ESP_OK == result) {
                    ESP_LOGI(TAG, "%s:%d Publishing message, topic: %s, payload: %s", __func__, __LINE__,topic.c_str(), payload.c_str());
                    mqtt->publish(topic, payload ) ;
                } else {
                    ESP_LOGE(TAG,"Error in queue" );
                }
                
              vTaskDelay(1000 / portTICK_RATE_MS);   //// DELAY 
            };   
        }
    };

Running this with wifi and mqtt the same message is published multiple times dependent on the line marked ///DELAY.

For me it looks like the line: !queue->empty not is updated directly when reading the queue. ??? Depending on what is happening in rest of the application it is updated or not.....

The queue supposed to work so ???
If so,, how do you use it in the best way....

[howroyd]

For some reason I didn't get a notification for this issue. My apologies.

Did you find the answer?

My gut feeling is that this return should be volatile as it can be effected by multiple cores. Then, followed forward, I would make the empty() call also return a volatile:

esp32_youtube_series/application/TaskMessaging/TaskMessaging.h

Line 170 in e8cf2ad

[[nodiscard]] size_t n_items_waiting(void) const