Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving network error handling #5763

Closed
26 tasks
HelNershingThapa opened this issue May 5, 2023 · 1 comment · Fixed by #5954
Closed
26 tasks

Improving network error handling #5763

HelNershingThapa opened this issue May 5, 2023 · 1 comment · Fixed by #5954
Assignees

Comments

@HelNershingThapa
Copy link
Contributor

HelNershingThapa commented May 5, 2023

Is your feature request related to a problem? Please describe.
Our app's current network error handling leaves much to be desired, often causing crashes or indefinite loading indicators.

This is not an exhaustive list and includes nothing from the management sections. So feel free to add to this list if you encounter issues elsewhere. Or provide more details for each item.

Landing Page

Explore Projects Page

  • The app crashes when the campaign, organization, location, or interests filters fail to fetch.

My Contributions Page

  • The header profile doesn't show any affiliated organizations if fetching organizations fail. teams
  • The teams will keep loading forever if fetching them fails.
    teams-contrib

Project Detail Page

  • Error handling for project detail loading only accounts for private project errors, and as a result, the fallback error handling displays "Project not found" when any other error occurs.
    project-not-found
  • The loading indicator for the contribution timeline section continues to show indefinitely, even after the API has failed.
    contrib-timeline-deet
  • The loading indicator for the contribution timeline section continues to show indefinitely, even after the API has failed.
    contributors-list
  • The app crashes or becomes unresponsive when loading questions, comments, or navigating with pagination buttons.

Project's Tasks Selection Page

  • The app displays the "failed to fetch" text when it fails to retrieve the project's summary.
    tasks-list-page
  • The loading indicator for the contribution timeline section continues to show indefinitely, even after fetching activities for a project fails.
    screencapture-127-0-0-1-3000-projects-1-tasks-2023-05-04-13_28_45
  • The app crashes when the user contributions endpoint fails.
  • The app crashes when it fails to load the latest activities.

Task Detail Modal

  • The app does not display a loading indicator when loading comments or activities, and it shows an empty container instead of an error message when it fails to load.
    empty-activities
  • When a comment POST fails, the app does not display any error message to inform the user.

Task Action Page

  • The app always navigates the user to the tasks page when failing to fetch information about the user's locked tasks, without handling the error.
  • The app experiences a forever loading issue on the task action page when failing to fetch the project summary.
    screencapture-127-0-0-1-3000-projects-1-map-2023-05-04-13_41_39
  • When there is a failure to fetch project tasks, the app is currently crashing
  • When the task history fails, the app provides no UI indication to inform the user of the failure. There is no loading indicator, and the app behaves the same as when there is no error
  • When there is a failure to load priority areas, the app is not currently providing any response in the UI
  • When submitting a task fails or when trying to select another task, the app is not currently providing any response in the UI
  • The app always shows the same error message when attempting to split a task, regardless of the actual error.
    split task

Project Stats Page

  • When the app fails to load the project summary, the stats page becomes stuck in an indefinite loading state.
    screencapture-127-0-0-1-3000-projects-2-2023-05-04-10_31_11
  • If loading project tasks fails, all stat numbers are shown as zero.
    task-by-status-fails
  • Loading the contributors' section leads to an indefinite loading state.
    contributors-forever
  • Loading the project timeline leads to an indefinite loading state.
    project-timeline
  • Loading the time statistics section leads to an indefinite loading state.
    timestatistics-forever
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants