Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add code conventions via linting/prettier tooling #110

Closed
Tracked by #61
0xjjpa opened this issue Jan 27, 2022 · 1 comment
Closed
Tracked by #61

Add code conventions via linting/prettier tooling #110

0xjjpa opened this issue Jan 27, 2022 · 1 comment
Labels
feature New feature or request

Comments

@0xjjpa
Copy link
Contributor

0xjjpa commented Jan 27, 2022

Is your feature related to a problem?

Currently there are no code conventions on the project.

Describe the feature you'd like

Ideally we use something like js-standard and enforce via prettier and githooks to run linters on commit/push.

Describe alternatives you've considered

Auto-commits as we do in hoprnet, but CI feels like the wrong place to deal with this (wasting CI cycles on code that wasn't verified in the workstation).

Additional context

This is relevant for our contribution guidelines.

@0xjjpa 0xjjpa added the feature New feature or request label Jan 27, 2022
@0xjjpa 0xjjpa added this to the v0.4 (UX improvements) milestone Feb 14, 2022
@mjadach-iv
Copy link
Contributor

Closing issue as the myne-chat project is closed for the time being.
Will need to reopen if we will be updating the repo.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants