Update HOPR Staking Contract for Seasons 3 and 4

[thewanderingeditor]

Issue deadline

April 19th

Detailed Description

This is part of #207

The HOPR staking program will move from Season 2 to Season 3 at 2pm CET on April 26th. To prepare for this change, the staking contract will need to be updated and redeployed.

The following changes need to be made:

Required Changes

• New start and end dates
• Fix to the bug which caused some tokens to be locked at the end of Season 1: Remove require in _claim - RIP ☠️  hopr-stake#51
• Update how certain NFT types are handled to match the results of the NFT audit (NFT Program Cost Audit #213)
• Update base APR and Boost Cap values, depending on the results of the NFT audit (NFT Program Cost Audit #213)

Possible Changes

• New rules to mitigate issues surrounding the new Developer NFT which grants immediate access to the whitelist

UPDATE: It was also decided that we would prepare and deploy the Season 4 contract at this time.

Parameters for Seasons 3 and 4

Parameter	Season 3	Season 4
Start Date*	April 26th	July 26th
End Date*	July 26th	October 26th
Base APR	10%	10%
Boost Cap	150k	150k
Ignored NFTs	HODLr	HODLr + S1**

*All times are 2pm CET
** The S1 ranks are DAO_v2, Surveyor, Wildhorn_v1, Wildhorn_v2, PuzzleHunt_v1, PuzzleHunt_v2

[thewanderingeditor]

Start and end dates set as 26th April 2pm CET - 26th July 2pm CET

Boost cap to be reduced from 1m to 150k

Base APR to be reduced to 10%

HODLr NFTs to be ignored

[QYuQianchen]

Could you please update parameters for S4? @thewanderingeditor

[thewanderingeditor]

Could you please update parameters for S4? @thewanderingeditor

Updated in issue

[QYuQianchen]

BTW, "Wildhorn v2" appeared twice: Wildhorn_v2 and Wildhorn v2

** The S1 ranks are DAO_v2, Surveyor, Wildhorn_v2, Wildhorn v2, PuzzleHunt_v1, PuzzleHunt_v2

[thewanderingeditor]

BTW, "Wildhorn v2" appeared twice: Wildhorn_v2 and Wildhorn v2

** The S1 ranks are DAO_v2, Surveyor, Wildhorn_v2, Wildhorn v2, PuzzleHunt_v1, PuzzleHunt_v2

Thanks. Should have been both v1 and v2. Updated.

[QYuQianchen]

Note that, to simplify SC work, the blocklist would affect NFT redemption in such a way:

1. Before an NFT type gets blocked, stakers can stake those NFTs and get a booster in APY;
2. After an NFT type gets blocked, no more NFT of the blocked type can be redeemed (tx will be reverted), and thus no new booster from blocked NFTs. However the previously redeemed NFTs will still be affective, so stakers who did step 1 will still benefit from the boosted APY.
3. If the blocked NFT type gets "unblocked" (allowed), then those NFTs can be redeemed again.

[QYuQianchen]

RE "Dev NFT", see discussion thread, we have decided on issuing "0% APY" HoprBoost NFT to devs. Devs can then stake those NFTs in the latest staking season.
NetworkRegistryProxy will be updated to always treat "Dev NFT" type as "eligible" tokens. Devs (Ethereum accounts that hold "Dev" NFTs) can then call selfRegister(string HoprNode) by providing the multiaddress of their node to the HoprNetworkRegistry smart contract. Upon successful registration, hopr-core will allow connection to those nodes.