Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggestion for Improving Test Coverage of utils/buffer.ts #2995

Closed
yasuaki640 opened this issue Jun 19, 2024 · 2 comments · Fixed by #3004
Closed

Suggestion for Improving Test Coverage of utils/buffer.ts #2995

yasuaki640 opened this issue Jun 19, 2024 · 2 comments · Fixed by #3004
Labels
enhancement New feature or request.

Comments

@yasuaki640
Copy link
Contributor

yasuaki640 commented Jun 19, 2024

What is the feature you are proposing?

The equals function in utils/buffer.ts does not appear to be used.

https://app.codecov.io/github/honojs/hono/blob/main/src%2Futils%2Fbuffer.ts#L9

If it is a function used on the user side, I would suggest adding test code.
Or, if it is not going to be used in the future, it would be better to remove it.

If either of these fixes are needed, I will send out a pull request!
If no modifications are needed, the issue should be closed!

@yasuaki640 yasuaki640 added the enhancement New feature or request. label Jun 19, 2024
@yusukebe
Copy link
Member

Hi @yasuaki640

Thank you for your suggestion. It may be no problem to remove it if it's not used anywhere in the hono package. But someone may use it (initially, though utils are created for internal use only), and it's not hard to maintain it. So, let's keep it.

Can you write tests? I would really like you to write the whole test for utils/buffer.ts.

@yasuaki640
Copy link
Contributor Author

@yusukebe

Can you write tests? I would really like you to write the whole test for utils/buffer.ts.

Understood. I will try.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants