Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CORS MW causes issues with Vary header. #2932

Closed
fishcakeday opened this issue Jun 7, 2024 · 1 comment · Fixed by #2934
Closed

CORS MW causes issues with Vary header. #2932

fishcakeday opened this issue Jun 7, 2024 · 1 comment · Fixed by #2934

Comments

@fishcakeday
Copy link

set('Vary', 'Origin')

CORS middleware overrides Vary headers without checking for existing ones and causes a lot of issues with variable image types served based on Accept header. Please consider making it so it either merges into existing headers or leaves it alone if it is present.

@fzn0x
Copy link
Contributor

fzn0x commented Jun 7, 2024

Fixed in my PR, review are appreciated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants