Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: husky #367

Merged
merged 3 commits into from
Oct 25, 2024
Merged

feat: husky #367

merged 3 commits into from
Oct 25, 2024

Conversation

hongaar
Copy link
Owner

@hongaar hongaar commented Oct 25, 2024

This pull request includes changes to improve the handling of pre-commit hooks and to clean up the package.json scripts. The most important changes involve modifying the pre-commit hook setup and command management in the husky plugin, and cleaning up the pre-commit hook script.

Improvements to pre-commit hook handling:

  • .husky/pre-commit: Removed the initialization lines and simplified the script to only include the necessary commands. ([.husky/pre-commitL1-L3](https://github.com/hongaar/moker/pull/367/files#diff-d2bc4bbf14eadc292d84e0ef5f7a93115c23557f533809fc80b896934291529dL1-L3))
  • packages/plugins/src/husky/husky.ts: Updated the addPreCommitHookCommand function to use setPreCommitHookCommands for managing multiple commands. ([packages/plugins/src/husky/husky.tsL124-R126](https://github.com/hongaar/moker/pull/367/files#diff-f6408bd0d6b3d60417475096443d24610f6fb92a44efd7365a1748e44119e726L124-R126))
  • packages/plugins/src/husky/husky.ts: Modified the removePreCommitHookCommand function to remove the pre-commit hook file when no commands are left. ([packages/plugins/src/husky/husky.tsL142-R143](https://github.com/hongaar/moker/pull/367/files#diff-f6408bd0d6b3d60417475096443d24610f6fb92a44efd7365a1748e44119e726L142-R143))

Cleanup in package.json scripts:

  • package.json: Removed and re-added the build:watch script to maintain consistency in script formatting. ([package.jsonL14-R15](https://github.com/hongaar/moker/pull/367/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L14-R15))

@hongaar hongaar merged commit 0603773 into main Oct 25, 2024
7 checks passed
@hongaar hongaar deleted the feat/husky branch October 25, 2024 12:14
hongaar pushed a commit that referenced this pull request Oct 25, 2024
# [4.3.0](v4.2.0...v4.3.0) (2024-10-25)

### Features

* husky ([#367](#367)) ([0603773](0603773)), closes [/#diff-d2bc4bbf14eadc292d84e0ef5f7a93115c23557f533809fc80b896934291529dL1-L3](https://github.com///issues/diff-d2bc4bbf14eadc292d84e0ef5f7a93115c23557f533809fc80b896934291529dL1-L3) [/#diff-d2bc4bbf14eadc292d84e0ef5f7a93115c23557f533809fc80b896934291529dL1-L3](https://github.com///issues/diff-d2bc4bbf14eadc292d84e0ef5f7a93115c23557f533809fc80b896934291529dL1-L3) [/#diff-f6408bd0d6b3d60417475096443d24610f6fb92a44efd7365a1748e44119e726L124-R126](https://github.com///issues/diff-f6408bd0d6b3d60417475096443d24610f6fb92a44efd7365a1748e44119e726L124-R126) [/#diff-f6408bd0d6b3d60417475096443d24610f6fb92a44efd7365a1748e44119e726L124-R126](https://github.com///issues/diff-f6408bd0d6b3d60417475096443d24610f6fb92a44efd7365a1748e44119e726L124-R126) [/#diff-f6408bd0d6b3d60417475096443d24610f6fb92a44efd7365a1748e44119e726L142-R143](https://github.com///issues/diff-f6408bd0d6b3d60417475096443d24610f6fb92a44efd7365a1748e44119e726L142-R143) [/#diff-f6408bd0d6b3d60417475096443d24610f6fb92a44efd7365a1748e44119e726L142-R143](https://github.com///issues/diff-f6408bd0d6b3d60417475096443d24610f6fb92a44efd7365a1748e44119e726L142-R143) [/#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L14-R15](https://github.com///issues/diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L14-R15) [/#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L14-R15](https://github.com///issues/diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519L14-R15)

[skip ci]
@hongaar
Copy link
Owner Author

hongaar commented Oct 25, 2024

🎉 This PR is included in version 4.3.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant