Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve filtering syntax #47

Open
dkumiszhan opened this issue Jun 14, 2023 · 1 comment
Open

Improve filtering syntax #47

dkumiszhan opened this issue Jun 14, 2023 · 1 comment
Labels
enhancement New feature or request javascript Pull requests that update Javascript code

Comments

@dkumiszhan
Copy link
Collaborator

dkumiszhan commented Jun 14, 2023 •
edited by glaslos
Loading

In #46 we introduced the initial version of filtering syntax using chevrotain. We need to improve the syntax by adding new features.

Some things to consider:

  • Should we support operators like contains or matches?
  • Should we support in operator?
  • Should we support "unary" clause (for example tcp, ip.src, etc)?
  • How can we filter by payload? Implement payload contains filtering #57
@dkumiszhan dkumiszhan mentioned this issue Jun 14, 2023
Merged
@glaslos glaslos added enhancement New feature or request javascript Pull requests that update Javascript code labels Jun 25, 2023
@ashutosh887
Copy link

@dkumiszhan @glaslos
If resolved, can we close this issue?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request javascript Pull requests that update Javascript code
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@glaslos @ashutosh887 @dkumiszhan