Skip to content
This repository has been archived by the owner on Dec 20, 2021. It is now read-only.

Multiple span references make spans lose their parent ID #69

Closed
william-tran opened this issue Apr 9, 2020 · 1 comment
Closed

Multiple span references make spans lose their parent ID #69

william-tran opened this issue Apr 9, 2020 · 1 comment
Assignees

Comments

@william-tran
Copy link

@Test
public void testMultipleParentSameTrace() {
    Span root = tracer.buildSpan("test-multi-parent-root").start();
    root.finish();
    Span span1 = tracer.buildSpan("test-multi-parent-span1").asChildOf(root).start();
    span1.finish();
    Span span2 = tracer.buildSpan("test-multi-parent-span2").asChildOf(root).start();
    span2.finish();
    Span span3 = tracer.buildSpan("test-multi-parent-span3").asChildOf(span1).asChildOf(span2).start();
    span3.finish();
}

image

image

I'm not sure if this is just a UI issue or if the data model is supposed to work this way. Steps to repro:

Fire up otel/opentelemetry-collector-contrib-dev:78e81f4ace962f8b613d5496218830cf05907c0f (latest to date) with this config:

receivers:
  jaeger:
    protocols:
      thrift_http:
exporters:
  honeycomb:
    api_key: ***
    dataset: "test"
    api_url: "https://api.honeycomb.io"
service:
  pipelines:
    traces:
      receivers: [jaeger]
      exporters: [honeycomb]

port forward 14268, clone https://github.com/william-tran/tracing-tests and run mvn test

@paulosman paulosman self-assigned this Apr 9, 2020
@william-tran
Copy link
Author

image

Turns out the problem is in io.jaegertracing.thriftjava.Span not having the parentId set. Sorry for the red herring.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants