maint: Add .tools-version file #188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MikeGoldsmith
added
the
type: maintenance
MikeGoldsmith
changed the title
robbkidd
reviewed
Mar 16, 2023
| @@ -0,0 +1 @@ | |||
| golang 1.18 | |||
There was a problem hiding this comment.
Sadly, I think this will result in Go 1.18.0, not "the latest 1.18.x".
There was a problem hiding this comment.
Yeah, you're correct - it only enforces the major.minor and doesn't care about the patch. However, this is a good step forward to where we didn't enforce any version.
There's an open PR in asdf to try to tackle it but there's mixed opinion on whether it should be part of the core tool or the plugins.
Are you okay with this to start with, then if the asdf supports 'latest' patches we move to that?
|
Closing this PR based on @robbkidd's comment about asdf forcing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Which problem is this PR solving?
Adds a
.tools-versionfile that indicates what version of go should be used with the project. In this case I matched what we build our binaries with in CircleCI (1.18).Short description of the changes
.tools-versionfile that sets go version to 1.18