Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make Honeybadger.setNotifier an abstract method #1145

Open
subzero10 opened this issue Jul 26, 2023 · 0 comments
Open

Make Honeybadger.setNotifier an abstract method #1145

subzero10 opened this issue Jul 26, 2023 · 0 comments

Comments

@subzero10
Copy link
Member

With the recent introduction of notifier per package, we want to take advantage of Typescript and make sure we set a new notifier identifier for every new js client integration.
This can be done by modifying the setNotifier method to be abstract.
With this approach, we should:

  • Have a class extending the base class for each client integration (i.e. HonebyadgerReactClient, HoneybadgerVueClient, etc). The extending classes could extend of the HoneybadgerJsClient (not the core client). These classes will implement the setNotifier() method.
  • Challenge: The @honeybadger-io/js package should not export a singleton, but rather the class itself so it can be extended and instantiated by the target package (vue, react, etc.)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant