You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
With the recent introduction of notifier per package, we want to take advantage of Typescript and make sure we set a new notifier identifier for every new js client integration.
This can be done by modifying the setNotifier method to be abstract.
With this approach, we should:
Have a class extending the base class for each client integration (i.e. HonebyadgerReactClient, HoneybadgerVueClient, etc). The extending classes could extend of the HoneybadgerJsClient (not the core client). These classes will implement the setNotifier() method.
Challenge: The @honeybadger-io/js package should not export a singleton, but rather the class itself so it can be extended and instantiated by the target package (vue, react, etc.)
The text was updated successfully, but these errors were encountered:
With the recent introduction of notifier per package, we want to take advantage of Typescript and make sure we set a new notifier identifier for every new js client integration.
This can be done by modifying the
setNotifier
method to beabstract
.With this approach, we should:
HonebyadgerReactClient
,HoneybadgerVueClient
, etc). The extending classes could extend of theHoneybadgerJsClient
(not the core client). These classes will implement thesetNotifier()
method.@honeybadger-io/js
package should not export a singleton, but rather the class itself so it can be extended and instantiated by the target package (vue, react, etc.)The text was updated successfully, but these errors were encountered: