Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

:feelsgood:🚥🐛 Run only Firefox on CI (fixes noref) #8

Merged
merged 1 commit into from
Jul 29, 2016

Conversation

SpainTrain
Copy link
Member

@SpainTrain SpainTrain commented Jul 29, 2016

Karma tests continue to fail due to full page reload, only with
Chrome and only within CircleCI. For now, will not run tests on Chrome
in CircleCI.

related #7


This change is Reviewable

Karma tests continue to fail due to full page reload, only with
Chrome and only within CircleCI. For now, will not run tests on Chrome
in CircleCI.

related homezen#7
@SpainTrain
Copy link
Member Author

Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@codecov-io
Copy link

Current coverage is 96.45% (diff: 100%)

Merging #8 into master will not change coverage

@@             master         #8   diff @@
==========================================
  Files             8          8          
  Lines           141        141          
  Methods          30         30          
  Messages          0          0          
  Branches          9          9          
==========================================
  Hits            136        136          
  Misses            5          5          
  Partials          0          0          

Sunburst

Powered by Codecov. Last update f3586ef...e8917c5

@pcgilday
Copy link
Contributor

:shipit:


Reviewed 2 of 2 files at r1.
Review status: all files reviewed at latest revision, all discussions resolved.


Comments from Reviewable

@pcgilday pcgilday assigned SpainTrain and unassigned pcgilday Jul 29, 2016
@SpainTrain SpainTrain merged commit a4a172e into homezen:master Jul 29, 2016
@SpainTrain SpainTrain deleted the no-chrome-karma-on-ci branch July 29, 2016 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants