Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove global from ZHA application controller #19557

Merged
merged 3 commits into from
Dec 25, 2018
Merged

Remove global from ZHA application controller #19557

merged 3 commits into from
Dec 25, 2018

Conversation

dmulcahey
Copy link
Contributor

Remove global and stash ZHA's application controller in hass.data.

@MartinHjelmare Let me know if this isn't what you were thinking.

@ghost ghost added the in progress label Dec 24, 2018
MartinHjelmare
MartinHjelmare reviewed Dec 24, 2018
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Don't we need to access the controller from any other modules?

@dmulcahey
Copy link
Contributor Author

Don't we need to access the controller from any other modules?

@MartinHjelmare Nope. Everything is handled through events on the listener.

MartinHjelmare
MartinHjelmare approved these changes Dec 25, 2018
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@MartinHjelmare MartinHjelmare merged commit bef85ec into home-assistant:dev Dec 25, 2018
@ghost ghost removed the in progress label Dec 25, 2018
dshokouhi pushed a commit to dshokouhi/home-assistant that referenced this pull request Dec 25, 2018
@dmulcahey @dshokouhi
Remove global from ZHA application controller (home-assistant#19557)
dd1a4d0 
* remove global from application controller per request

* remove unneeded line

* don't store controller application in hass.data - review comment
@dmulcahey dmulcahey deleted the dm/zha-application-controller-global branch December 26, 2018 12:10
@balloob balloob mentioned this pull request Jan 10, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
cla-signed integration: zha small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dmulcahey @MartinHjelmare @homeassistant