Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use pysonos for Sonos media player #16753

Merged
merged 1 commit into from
Sep 20, 2018
Merged

Conversation

amelchio
Copy link
Contributor

Description:

Our third party Sonos library, the SoCo project, does quarterly releases. This means that bugs can linger for 5-10 Home Assistant releases before an upstream fix is available from PyPI.

To overcome this frustrating situation, I have forked SoCo and intend to add patches for issues like #13984 and #16661.

This PR simply moves Home Assistant to use my fork, pysonos 0.0.1. It is identical to SoCo 0.16, assuming I have made no errors in renaming things.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

Copy link
Member

@balloob balloob left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is fine, as long as we're staying ok with upstream.

Would be good to also notify them, as it might motivate them to improve their release cycle.

Do you envision still merging all your fixes upstream?

@amelchio
Copy link
Contributor Author

I did indeed plan to notify upstream if the change was accepted for Home Assistant. Now created an upstream issue mentioning the fork, SoCo/SoCo#638.

Yes, I expect to submit future PRs to SoCo as well.

@balloob balloob merged commit 78b6439 into home-assistant:dev Sep 20, 2018
@ghost ghost removed the in progress label Sep 20, 2018
@balloob balloob mentioned this pull request Sep 28, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants