Xiaomi Vacuum: keep error state active after erroring #16562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
platform: vacuum.xiaomi_miio
small-pr
ghost
assigned 
houndci-bot
reviewed
Sep 11, 2018
| @@ -179,6 +179,9 @@ def name(self): | |||
| def state(self): | |||
| """Return the status of the vacuum cleaner.""" | |||
| if self.vacuum_state is not None: | |||
| # We can have an error even when the state code does not indicate it (anymore). | |||
There was a problem hiding this comment.
line too long (91 > 79 characters)
rytilahti
changed the title
houndci-bot
reviewed
Sep 11, 2018
| @@ -179,6 +179,10 @@ def name(self): | |||
| def state(self): | |||
| """Return the status of the vacuum cleaner.""" | |||
| if self.vacuum_state is not None: | |||
| # The vacuum reverts back to an idle state after erroring out. | |||
| # We want to keep returning an error until it has been cleared. | |||
rytilahti
force-pushed
the
xiaomi_vac_error_handling
branch
from
6b5c7a1
to
cf34b0a
Compare
|
@syssi just to ping you that this can be merged after the python-miio gets bumped! |
|
It's still WIP. Let's close this and you can open new PR once lib has been updated? |
|
I'd prefer to keep it open (if not just as a reminder), but if you wish we can close this and I'll simply re-open when we have done a new release? |
|
Please reopen after release. We already have enough open PRs 👍 |
8 tasks
rytilahti
changed the title
|
I just created a PR to bump to the newest python-miio release (released last weekend). |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The vacuum returns back to an idle state after erroring, making it seem that there's no error anymore.
This will change this behaviour to keep the error state active.
A new python-miio release (with rytilahti/python-miio#379) is required for this to work.
Related issue (if applicable): fixes #
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):Checklist:
tox. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTSvariable (example).requirements_all.txtby runningscript/gen_requirements_all.py..coveragerc.If the code does not interact with devices: