Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for playing radio preset by Onkyo media_player #16258

Merged
merged 3 commits into from
Sep 3, 2018
Merged

Support for playing radio preset by Onkyo media_player #16258

merged 3 commits into from
Sep 3, 2018

Conversation

pszafer
Copy link
Contributor

@pszafer pszafer commented Aug 29, 2018 •
edited by MartinHjelmare
Loading

Description:

Current module is unable to switch radio station because of lack of playing capabilities.
I added fm/am/tuner radio support for now.

Currently not working for NET Radio, as it is a lot more complicated (needed to download XML from TuneIN/Spotify etc.) and then choose preset based on radio ID, not simple 1, 2, 3 etc.

Documentation:
home-assistant/home-assistant.io#6107

Usage:

      - service: media_player.play_media
        data:
          entity_id: media_player.onkyo
          media_content_type: "radio"
          media_content_id: "1"

Checklist:

  • [ x] The code change is tested and works locally.
  • [x ] Local tests pass with tox. Your PR cannot be merged unless tests pass

@ghost ghost added the in progress label Aug 29, 2018
@pszafer pszafer mentioned this pull request Aug 29, 2018
Merged
@MartinHjelmare
Copy link
Member

The first commit for mqtt cover is not related to this PR.

@pszafer
Copy link
Contributor Author

pszafer commented Aug 30, 2018

My bad, sorry. I removed this commit from this PR.

MartinHjelmare
MartinHjelmare reviewed Aug 30, 2018
View reviewed changes
Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to add support for SUPPORT_PLAY_MEDIA, right?

@pszafer
Copy link
Contributor Author

pszafer commented Sep 3, 2018

@MartinHjelmare is it ok right now?

@MartinHjelmare MartinHjelmare merged commit 00cba29 into home-assistant:dev Sep 3, 2018
@ghost ghost removed the in progress label Sep 3, 2018
girlpunk pushed a commit to girlpunk/home-assistant that referenced this pull request Sep 4, 2018
@pszafer
Support for playing radio preset by Onkyo media_player (home-assistan…
2ced023 
…t#16258)

* Added support to play radio preset by play media

* Switch radio station by preset for Onkyo

* added SUPPORT_PLAY_MEDIA
@balloob balloob mentioned this pull request Sep 17, 2018
Merged
@home-assistant home-assistant locked and limited conversation to collaborators Dec 10, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
cla-signed integration: mqtt integration: onkyo small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pszafer @MartinHjelmare @homeassistant