Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update Konnected configuration example for device id format validation #6066

Merged
merged 1 commit into from
Sep 1, 2018

Conversation

heythisisnate
Copy link
Contributor

Description:
The linked PR adds some stricter validation on device id in the Konnected configuration. This updates the examples and docs.

Pull request in home-assistant (if applicable): home-assistant/core#16146

Checklist:

  • Branch: Fixes, changes and adjustments should be created against current. New documentation for platforms/components and features should go to next.
  • The documentation follow the standards.

@ghost ghost added the to-do label Aug 23, 2018
@frenck frenck added new-feature This PR adds documentation for a new Home Assistant feature to an existing integration ready-for-review This PR needs to be reviewed next This PR goes into the next branch has-parent This PR has a parent PR in a other repo and removed to-do labels Aug 23, 2018
@treyrich
Copy link

@heythisisnate Might be worth noting that the device id must be in lowercase as well (got hung up on that today)

@heythisisnate
Copy link
Contributor Author

@frenck I just realized that this wasn't merged but the code changes were already released in 0.77. Now documentation is slightly wrong. Is there any way to get this published quickly?

Copy link
Contributor

@DubhAd DubhAd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@DubhAd DubhAd merged commit 00a880f into home-assistant:next Sep 1, 2018
@ghost ghost removed the ready-for-review This PR needs to be reviewed label Sep 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
has-parent This PR has a parent PR in a other repo new-feature This PR adds documentation for a new Home Assistant feature to an existing integration next This PR goes into the next branch
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants