Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to edit (save or delete) schedule time blocks on desktop Firefox - Edit schedule block just closes #23256

Closed
4 tasks done
richhollis opened this issue Dec 11, 2024 · 12 comments

Comments

@richhollis
Copy link

richhollis commented Dec 11, 2024

Checklist

  • I have updated to the latest available Home Assistant version.
  • I have cleared the cache of my browser.
  • I have tried a different browser to see if it is related to my browser.
  • I have tried reproducing the issue in safe mode to rule out problems with unsupported custom resources.

Describe the issue you are experiencing

Opening a helper schedule to edit.

Clicking on an existing time block to change the times, which opens the Edit schedule block dialog.

Clicking "Save" in the Edit schedule block causes the dialog to just shut and fully exist the schedule editing, returning you back to the main helper list.

No changes are saved or remembered when opening the schedule again.

Pretty sure this was not an issue in core_2024.11.3.

I tested on Chrome and it works as expected.

It also works fine on my Pixel 6 Android companion app.

Unrelated: The other strange thing about schedules is that sometimes they go back to the Integrations page after editing, not back to the previous Helper list view. That's been happening for quite some time.

Describe the behavior you expected

The Edit schedule block dialog should close normally and return the user back to the Schedule for viewing or further editing, showing any changes that were just made.

Steps to reproduce the issue

  1. Open schedule
  2. Edit Time block
  3. Press Save
    ...

What version of Home Assistant Core has the issue?

core_2024.12.2

What was the last working version of Home Assistant Core?

core_2024.11.3

In which browser are you experiencing the issue with?

Firefox 132.0.1 (64-bit)

Which operating system are you using to run this browser?

5.15.0-107-generic #117~20.04.1-Ubuntu SMP Tue Apr 30 10:35:57 UTC 2024 x86_64 x86_64 x86_64 GNU/Linux

State of relevant entities

No response

Problem-relevant frontend configuration

No response

Javascript errors shown in your browser console/inspector

No response

Additional information

No response

@jeroenvdw
Copy link

I have the same issue: can't edit/add/delete time blocks in the GUI.
Not able to do so in Chrome/Edge/Firefox. Also not able to do it in companion app on Android.
Tried with direct link (192.168.1.x) and after Cloudflare. Both without success.

@Ricket
Copy link

Ricket commented Dec 14, 2024

In my case I hit this bug in Firefox but I was able to make the edit successfully in Chrome. It was a few days ago though, I was probably on 2024.12.2. (I keep my HA up to date with watchtower)

@karwosts
Copy link
Contributor

I haven't checked specifically for this, but I do know a lot of changes have been going into dialog navigation this month (hopefully fix the old back button navigation issue). I'm hopeful it will be resolved in the Jan release.

@terba
Copy link

terba commented Jan 3, 2025

I have the same especially when the editor is opened from the scheduler's more-info dialog (via the cog icon).

@atomiclama
Copy link

atomiclama commented Jan 7, 2025

I have similar problems when using Firefox on Ubuntu but it's fine when using Chrome on Windows

The main problem I have is I use the data block to hold the temperature of my climate control for different periods during the day.
Following examples from: -
https://www.home-assistant.io/integrations/schedule/

Now if I move the schedule block the data block i.e. the temperature setting is lost

@terba
Copy link

terba commented Jan 7, 2025

Regardless of the browser the additional data gets lost when an entry is moved or resized. It's very annoying to remember this behaviour and clipboard the data before to prevent data loss.

@richhollis
Copy link
Author

richhollis commented Jan 7, 2025

I think this has been fixed in 2025.1.0. I've just tried it and it seems fine now. If somebody else with the same problem wants to confirm it's good then we can probably close this issue.

@atomiclama
Copy link

I'll update when I next get a chance and report back. Thanks for the heads up.

@terba
Copy link

terba commented Jan 7, 2025

I upgraded to 2025.1.1 and after a cache clear (Ctrl+F5) it works as it should in Firefox too. I open a new issue for the other problem (data loss), as it is still there.

@terba
Copy link

terba commented Jan 7, 2025

Data loss issue created as #23617

@karwosts
Copy link
Contributor

karwosts commented Jan 8, 2025

Fix has merged for lost data on move or resize. Thanks for reporting.

@terba
Copy link

terba commented Jan 8, 2025

Thanks for the fast fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

6 participants