Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pyhaversion to 2.0.2 #18318

Merged
merged 1 commit into from
Nov 8, 2018
Merged

Bump pyhaversion to 2.0.2 #18318

merged 1 commit into from
Nov 8, 2018

Conversation

ludeeus
Copy link
Member

@ludeeus ludeeus commented Nov 8, 2018

Description:

Fixes an issue with the new features added in sensor.version reported in the #beta channel on Discord.
https://discordapp.com/channels/330944238910963714/427516175237382144/509922015759564800

Where this configuration:

sensor:
  - platform: version
    image: qemux86-64
    source: hassio

Resulted in this message:

Error fetching version information for hassio, 'qemux86-64'

As a result of that, the sensor did not show version attributes for supervisor, cli or hassos, only homeassistant.

Related issue (if applicable): fixes #

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#<home-assistant.io PR number goes here>

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ludeeus ludeeus requested a review from fabaff as a code owner November 8, 2018 07:48
@ghost ghost added the in progress label Nov 8, 2018
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit 7fed49c into home-assistant:dev Nov 8, 2018
@ghost ghost removed the in progress label Nov 8, 2018
@ludeeus ludeeus deleted the pyhaversion_bump branch November 8, 2018 08:30
@balloob balloob added this to the 0.82 milestone Nov 8, 2018
balloob pushed a commit that referenced this pull request Nov 8, 2018
@balloob balloob mentioned this pull request Nov 9, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants