Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve opentherm_gw state detection #16809

Merged
merged 1 commit into from
Sep 23, 2018
Merged

Conversation

mvn23
Copy link
Contributor

@mvn23 mvn23 commented Sep 23, 2018

Only show the platform in STATE_HEAT when the boiler is actually heating.

Description:

DATA_SLAVE_CH_ACTIVE does not necessarily indicate that the boiler is actually heating. We should check that DATA_SLAVE_FLAME_ON is true as well.

Related issue (if applicable): N/A

Pull request in home-assistant.io with documentation (if applicable): N/A

Example entry for configuration.yaml (if applicable):

N/A

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

  • N/A

If the code communicates with devices, web services, or third-party tools:

  • No new files/dependencies

If the code does not interact with devices:

  • N/A

Only show the platform in STATE_HEAT when the boiler is actually heating.
@MartinHjelmare MartinHjelmare merged commit 329d9df into home-assistant:dev Sep 23, 2018
@ghost ghost removed the in progress label Sep 23, 2018
@mvn23 mvn23 deleted the patch-1 branch September 23, 2018 21:01
@balloob balloob mentioned this pull request Sep 28, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants