Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add configurable host for bbox routers #16778

Merged
merged 4 commits into from
Sep 23, 2018
Merged

Add configurable host for bbox routers #16778

merged 4 commits into from
Sep 23, 2018

Conversation

isonet
Copy link
Contributor

@isonet isonet commented Sep 21, 2018

Add configurable host for bbox router running on non-default IP addresses.

Description:

The current implementation only supports bbox routers running on 192.168.1.254. I added a configuration entry to set the router IP address.

Pull request in home-assistant.io with documentation (if applicable): home-assistant/home-assistant.io#6333

Example entry for configuration.yaml (if applicable):

device_tracker:
  - platform: bbox
    host: 192.168.1.1

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • [N/A] New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • [N/A] New dependencies are only imported inside functions that use them ([example][ex-import]).
  • [N/A] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • [N/A] New files were added to .coveragerc.

If the code does not interact with devices:

  • [N/A] Tests have been added to verify that the new code works.

Add configurable host for bbox router running on non-default IP addresses.
@homeassistant
Copy link
Contributor

Hi @isonet,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!


import homeassistant.helpers.config_validation as cv
from homeassistant.components.device_tracker import (
PLATFORM_SCHEMA, CONF_SCAN_INTERVAL, DEFAULT_SCAN_INTERVAL, DOMAIN, DeviceScanner)

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (86 > 79 characters)

homeassistant/components/device_tracker/bbox.py Outdated Show resolved Hide resolved
isonet and others added 3 commits September 21, 2018 21:43
Fix unused import which also resolves "line too long"
@ghost ghost assigned fabaff Sep 23, 2018
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks 🐦

@fabaff fabaff merged commit eaee551 into home-assistant:dev Sep 23, 2018
@ghost ghost removed the in progress label Sep 23, 2018
@balloob balloob mentioned this pull request Sep 28, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants