Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add confirmation to Cast/Sonos/iOS config entries #16769

Merged
merged 2 commits into from
Sep 21, 2018
Merged

Add confirmation to Cast/Sonos/iOS config entries #16769

merged 2 commits into from
Sep 21, 2018

Conversation

balloob
Copy link
Member

@balloob balloob commented Sep 21, 2018

Description:

Adds confirmation step to config entries Cast, Sonos and iOS. Old behavior was a "Success!" message when clicking configure.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from a team as a code owner September 21, 2018 09:19
@ghost ghost assigned balloob Sep 21, 2018
@ghost ghost added the in progress label Sep 21, 2018
@pvizeli pvizeli merged commit 8b42d0c into dev Sep 21, 2018
@ghost ghost removed the in progress label Sep 21, 2018
@pvizeli pvizeli deleted the confirmation-sonos-cast branch September 21, 2018 14:34
@balloob balloob mentioned this pull request Sep 28, 2018
Merged
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pvizeli pvizeli pvizeli approved these changes

Assignees

@balloob balloob

Labels
cla-signed core
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@balloob @pvizeli @homeassistant