Avoid calling yr update every second for a minute ones every hour #16731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
homeassistant
added
platform: sensor.yr
small-pr
ghost
assigned 
houndci-bot
reviewed
Sep 20, 2018
| @@ -91,7 +91,7 @@ | |||
| async_add_entities(dev) | |||
|
|
|||
| weather = YrData(hass, coordinates, forecast, dev) | |||
| async_track_utc_time_change(hass, weather.updating_devices, minute=31) | |||
| async_track_utc_time_change(hass, weather.updating_devices, minute=31, second=0) | |||
There was a problem hiding this comment.
line too long (84 > 79 characters)
Danielhiversen
changed the title
|
omg. |
balloob
approved these changes
Sep 20, 2018
|
I wonder if we should change the defaults on this function. If you pass in minute, seconds defaults to 0. |
|
It is not fetching new data from the server that often, but it is iterating over the self.data dict. Yeah, it might be a good idea to change the default. |
|
Oh, it's throttled, good. Great catch |
|
Removing it from milestone as it's not critical. |
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Avoid calling yr update every second for a minute ones every hour
Checklist:
tox. Your PR cannot be merged unless tests pass