Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add subscription info endpoint #16727

Merged
merged 5 commits into from
Sep 20, 2018
Merged

Add subscription info endpoint #16727

merged 5 commits into from
Sep 20, 2018

Conversation

balloob
Copy link
Member

@balloob balloob commented Sep 19, 2018

Description:

This improves the subscription info endpoint for cloud component.

Frontend: home-assistant/frontend#1685

Example entry for configuration.yaml (if applicable):

cloud:

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@balloob balloob requested a review from a team as a code owner September 19, 2018 22:42
@ghost ghost assigned balloob Sep 19, 2018
@ghost ghost added the in progress label Sep 19, 2018
houndci-bot
houndci-bot reviewed Sep 19, 2018
View reviewed changes
tests/components/cloud/test_http_api.py Outdated
}


async def test_websocket_subscription(hass, hass_ws_client, aioclient_mock,
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

redefinition of unused 'test_websocket_subscription' from line 358

@balloob balloob mentioned this pull request Sep 19, 2018
Merged
@balloob balloob merged commit e58836f into dev Sep 20, 2018
@balloob balloob deleted the sub-info branch September 20, 2018 12:53
@ghost ghost removed the in progress label Sep 20, 2018
@balloob balloob mentioned this pull request Sep 28, 2018
Merged
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@houndci-bot houndci-bot houndci-bot left review comments

@pvizeli pvizeli pvizeli approved these changes

Assignees

@balloob balloob

Labels
cla-signed core integration: cloud integration: websocket_api
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@balloob @houndci-bot @pvizeli @homeassistant