On-demand update of swiss public transport sensor #16723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…has crossed). Looking at the documentation on https://transport.opendata.ch/docs.html, delay information is available only on stationboard, so no need to query often if there is no "real"time info.
…catch client errors like throttling rejection (HTTP 429)
homeassistant
added
cla-signed
platform: sensor.swiss_public_transport
small-pr
houndci-bot
reviewed
Sep 19, 2018
fabaff
changed the title
fabaff
approved these changes
Sep 20, 2018
| @@ -111,7 +112,7 @@ def device_state_attributes(self): | |||
| ATTR_DEPARTURE_TIME2: self._opendata.connections[2]['departure'], | |||
| ATTR_START: self._opendata.from_name, | |||
| ATTR_TARGET: self._opendata.to_name, | |||
| ATTR_REMAINING_TIME: '{}'.format(remaining_time), | |||
| ATTR_REMAINING_TIME: '{}'.format(self._remaining_time), | |||
There was a problem hiding this comment.
We don't want to store relative (to now) times in the state machine as they spam it.
There was a problem hiding this comment.
I see, it is an existing attribute. I don't use it / dont see a need for it - don't know what is the adoption.
Agree this does not necessarily be in state machine and can be calculated in a template only by whom who needs it.
Do you recommend deprecating this attribute?
There was a problem hiding this comment.
I would say so yes. @fabaff do you agree?
Merged
ghost
added
integration: swiss_public_transport
and removed
platform: sensor.swiss_public_transport
labels
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Changing Swiss Public Transport sensor to update it's values only when required (only after the train has crossed)
Related issue (if applicable): fixes #9012
(Linking to old issue as the issue has not dissapeared completely and this pull request is extension of previous fix to change it from 90 seconds to on-demand)
Closes home-assistant-ecosystem/python-opendata-transport#3
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: