Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unique_id to mqtt_json light #16721

Merged

Conversation

nikolaykasyanov
Copy link
Contributor

Description:

Applies changes from #16303 to mqtt_json component.

Related issue (if applicable): fixes #16600

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#6319

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable ([example][ex-requir]).
  • New dependencies are only imported inside functions that use them ([example][ex-import]).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@homeassistant
Copy link
Contributor

Hi @nikolaykasyanov,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@ghost ghost added in progress and removed platform: light.mqtt_json small-pr PRs with less than 30 lines. labels Sep 19, 2018
@@ -120,14 +123,15 @@
class MqttJson(MqttAvailability, Light):
"""Representation of a MQTT JSON light."""

def __init__(self, name, effect_list, topic, qos, retain, optimistic,
def __init__(self, name, unique_id, effect_list, topic, qos, retain, optimistic,

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

line too long (84 > 79 characters)

Applies changes from home-assistant#16303 to mqtt_json component.
Fixes home-assistant#16600.
Copy link
Member

@fabaff fabaff left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 🐦

@fabaff fabaff merged commit 27eede7 into home-assistant:dev Sep 20, 2018
@ghost ghost removed the in progress label Sep 20, 2018
@nikolaykasyanov nikolaykasyanov deleted the mqtt-json-light-unique-id branch September 20, 2018 06:47
@balloob balloob mentioned this pull request Sep 28, 2018
@OttoWinter OttoWinter mentioned this pull request Sep 28, 2018
4 tasks
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MQTT light isn't added to the entity register, doesn't have a button to change name & entity id
4 participants