-
-
Notifications
You must be signed in to change notification settings - Fork 31.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unique_id to mqtt_json light #16721
Add unique_id to mqtt_json light #16721
Conversation
Hi @nikolaykasyanov, It seems you haven't yet signed a CLA. Please do so here. Once you do that we will be able to review and accept this pull request. Thanks! |
@@ -120,14 +123,15 @@ | |||
class MqttJson(MqttAvailability, Light): | |||
"""Representation of a MQTT JSON light.""" | |||
|
|||
def __init__(self, name, effect_list, topic, qos, retain, optimistic, | |||
def __init__(self, name, unique_id, effect_list, topic, qos, retain, optimistic, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
line too long (84 > 79 characters)
Applies changes from home-assistant#16303 to mqtt_json component. Fixes home-assistant#16600.
994f645
to
a271342
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 🐦
Description:
Applies changes from #16303 to mqtt_json component.
Related issue (if applicable): fixes #16600
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#6319
Example entry for
configuration.yaml
(if applicable):Checklist:
tox
. Your PR cannot be merged unless tests passIf user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
REQUIREMENTS
variable ([example][ex-requir]).requirements_all.txt
by runningscript/gen_requirements_all.py
..coveragerc
.If the code does not interact with devices: