Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes an AirVisual bug where response data is missing #16673

Merged
merged 1 commit into from
Sep 17, 2018

Conversation

bachya
Copy link
Contributor

@bachya bachya commented Sep 17, 2018

Description:

"Fixes" #16639 (in that an error is logged instead of an uncaught exception bubbling up).

Related issue (if applicable): fixes #16639

Pull request in home-assistant.github.io with documentation (if applicable): N/A

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: airvisual
    api_key: <API_KEY>
    monitored_conditions:
      - us

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:
- [ ] Documentation added/updated in home-assistant.github.io

If the code communicates with devices, web services, or third-party tools:
- [ ] New dependencies have been added to the REQUIREMENTS variable (example).
- [ ] New dependencies are only imported inside functions that use them (example).
- [ ] New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
- [ ] New files were added to .coveragerc.

If the code does not interact with devices:
- [ ] Tests have been added to verify that the new code works.

@ghost ghost assigned bachya Sep 17, 2018
@ghost ghost added the in progress label Sep 17, 2018
@bachya bachya merged commit 27d50d3 into home-assistant:dev Sep 17, 2018
@ghost ghost removed the in progress label Sep 17, 2018
@bachya bachya deleted the airvisual-16639 branch September 17, 2018 20:44
@MartinHjelmare MartinHjelmare mentioned this pull request Sep 19, 2018
@balloob balloob mentioned this pull request Sep 28, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

airvisual exception on hass start
2 participants