Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Carbon Monoxide HomeKit Sensor #16664

Merged
merged 1 commit into from
Sep 21, 2018
Merged

Add Carbon Monoxide HomeKit Sensor #16664

merged 1 commit into from
Sep 21, 2018

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Sep 17, 2018

Description:

Add support for Carbon Monoxide Sensors in HomeKit as well as small cleanups. The sensor must have the co device_class to be mapped correctly. Either handled through HA or set manually in the customize section. I decided not to add entity_id mapping, since this would create conflicts with co2 sensors.

Feature Request: https://community.home-assistant.io/t/carbon-monoxide-sensor-support/68969

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#6300

Example entry for configuration.yaml (if applicable):

homeassistant:
  customize:
    sensor.carbon_monoxide:
      device_class: 'co'

homekit:

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass
  • Documentation added/updated in home-assistant.github.io
  • Tests have been added to verify that the new code works.

@ghost ghost assigned cdce8p Sep 17, 2018
@ghost ghost added in progress and removed cla-signed labels Sep 17, 2018
@cdce8p cdce8p merged commit 3bfe9e7 into home-assistant:dev Sep 21, 2018
@ghost ghost removed the in progress label Sep 21, 2018
@cdce8p cdce8p deleted the homekit-sensors branch September 21, 2018 10:51
@balloob balloob mentioned this pull request Sep 28, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants