Clean up device update, add via-hub #16659
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
houndci-bot
reviewed
Sep 17, 2018
| devices[device['id']] = DeviceEntry( | ||
| config_entries=set(device['config_entries']), | ||
| connections={tuple(conn) for conn in device['connections']}, | ||
| identifiers={tuple(iden) for iden in device['identifiers']}, |
There was a problem hiding this comment.
line too long (80 > 79 characters)
| for device in data['devices']: | ||
| devices[device['id']] = DeviceEntry( | ||
| config_entries=set(device['config_entries']), | ||
| connections={tuple(conn) for conn in device['connections']}, |
There was a problem hiding this comment.
line too long (80 > 79 characters)
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
via_huboption todevice_infoso that devices can indicate via what hub they are communicating.Docs PR: home-assistant/developers.home-assistant#88
CC @Kane610
Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: