Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log raw result of configure_reporting() command. #16655

Merged

Conversation

Adminiuga
Copy link
Contributor

Description:

This is an update to PR #16487
Xiaomi devices do not support ZCL configure_reporting command and instead of returning a ConfigureReportingResponse record they just fail with UNSUPPORTED_GENERAL_COMMAND so debug logging fails to parse result correctly. Instead we'll print the string representation of the whole response.

@damarco can you please retry this PR and let me know if it fixes your issue?

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

@ghost ghost added the in progress label Sep 17, 2018
@Danielhiversen Danielhiversen merged commit 44fdfdf into home-assistant:dev Sep 17, 2018
@ghost ghost removed the in progress label Sep 17, 2018
@Adminiuga Adminiuga deleted the zha-config-reporting-fix branch September 21, 2018 12:55
@balloob balloob mentioned this pull request Sep 28, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed integration: zha small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants