Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework timer delays #16650

Merged
merged 2 commits into from
Sep 17, 2018
Merged

Conversation

amelchio
Copy link
Contributor

Description:

@pvizeli noticed that #16598 ignores a quite important special case.

I have now reworked the timer so resetting – and startup – are no longer special cases (the first commit). We simply always delay until the next second rolls around.

The second commit adds back the well-known error message of an unsynchronized timer even though the reset is not explicit anymore.

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@amelchio amelchio requested a review from a team as a code owner September 16, 2018 20:37
@ghost ghost assigned amelchio Sep 16, 2018
@ghost ghost added the in progress label Sep 16, 2018
@amelchio amelchio removed their assignment Sep 16, 2018
@balloob balloob merged commit 3e0c6c1 into home-assistant:dev Sep 17, 2018
@ghost ghost removed the in progress label Sep 17, 2018
@balloob balloob mentioned this pull request Sep 28, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants