Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding support for RTDSContactSensor and RTDSMotionSensor in Tahoma … (RTS Alarms sensors and contacts for Somfy Protexiom alarms) #16609

Merged
merged 2 commits into from
Sep 14, 2018

Conversation

christopheBfr
Copy link
Contributor

Tahoma component:

Description:

This commit update the list of supported devices, adding 2 new Somfy devices (1 presence sensor and 1 contact sensor)

The way of managing the flag "available" has been changed in order to well manage the "available" flag for the 2 new sensors (not located on the same place than the other tahoma device in the device structure).

Tested using true tahoma and sensors on my RPI 2 + Hassbian.

Related issue (if applicable): fixes #

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>

Example entry for configuration.yaml (if applicable):

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@homeassistant
Copy link
Contributor

Hi @christopheBfr,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

@ghost ghost added the in progress label Sep 13, 2018
@christopheBfr christopheBfr changed the title Adding support for RTDSContactSensor and RTDSContactSensor in Tahoma … (RTS Alarms sensors and contacts for SOmfy Protexiom alarms) Adding support for RTDSContactSensor and RTDSContactSensor in Tahoma … (RTS Alarms sensors and contacts for Somfy Protexiom alarms) Sep 13, 2018
@christopheBfr christopheBfr changed the title Adding support for RTDSContactSensor and RTDSContactSensor in Tahoma … (RTS Alarms sensors and contacts for Somfy Protexiom alarms) Adding support for RTDSContactSensor and RTDSMotionSensor in Tahoma … (RTS Alarms sensors and contacts for Somfy Protexiom alarms) Sep 14, 2018
@bachya bachya merged commit 9c1a539 into home-assistant:dev Sep 14, 2018
@ghost ghost removed the in progress label Sep 14, 2018
@bachya
Copy link
Contributor

bachya commented Sep 14, 2018

Thanks! 😎

@balloob balloob mentioned this pull request Sep 28, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
@ghost ghost removed the platform: sensor.tahoma label Mar 21, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants