Improve precision of timer ticks #16598
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
The timer tries to tick a whole number of seconds since it was started. Thus, if it is started very close to a second rolling over, many ticks will fire on the wrong second. This is because we are usually a little bit late with scheduled tasks. I added a log statement to show this.
To help avoid these double and missed ticks, this PR delays the first tick until a second rolls over. This means that we can be almost one second late and still work as expected.
This is just an improvement, more complete fixes are discussed in home-assistant/architecture#50.
Checklist:
tox
.If the code does not interact with devices: