MQTT config entry #16594
Merged
MQTT config entry #16594
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
houndci-bot
reviewed
Sep 13, 2018
tests/components/mqtt/test_init.py
Outdated
|
|
||
|
|
||
| @asyncio.coroutine | ||
| def test_setup_without_tls_config_uses_tlsv1_under_python36(hass): | ||
| async def test_setup_without_tls_config_uses_tlsv1_under_python36(hass, mock_MQTT): |
There was a problem hiding this comment.
line too long (83 > 79 characters)
tests/components/mqtt/test_init.py
Outdated
|
|
||
|
|
||
| @asyncio.coroutine | ||
| def test_setup_uses_certificate_on_certificate_set_to_auto(hass): | ||
| async def test_setup_uses_certificate_on_certificate_set_to_auto(hass, mock_MQTT): |
There was a problem hiding this comment.
line too long (82 > 79 characters)
| certificate = os.path.join(os.path.dirname(__file__), | ||
| 'addtrustexternalcaroot.crt') | ||
| 'addtrustexternalcaroot.crt') |
There was a problem hiding this comment.
continuation line over-indented for visual indent
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This adds config entry support to MQTT. It's initially just limited to configuring just broker, port, username and password (last 2 are optional). I don't want to expose all advanced features, so this is a good start. Eventually I would want to add discovery, but that is little tricky as discovery requires access to the configuration.yaml.
This config entry takes a different approach than the other config entries: if a manual configuration is available, it will fail to setup the config entry. I'm actually not happy with that and will rework it, hence the WIP tag.It takes a slight different import to
importthan other config entries. Instead of absorbing the auth into an entry, it doesn't load anything and keeps loading from configuration.yaml. If the user removes configuration.yaml MQTT entry, the config entry will be removed.Once this PR is in, we can add support for Hass.io add-ons discovering MQTT config entry 👍
Depends on home-assistant/frontend#1662
Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.github.io#<home-assistant.github.io PR number goes here>
Example entry for
configuration.yaml(if applicable):# None! :-)Checklist:
tox. Your PR cannot be merged unless tests passIf the code does not interact with devices: