Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo #16556

Merged
merged 1 commit into from
Sep 11, 2018
Merged

Fix typo #16556

merged 1 commit into from
Sep 11, 2018

Conversation

balloob
Copy link
Member

@balloob balloob commented Sep 11, 2018

Description:

Fix a typo in restoring old auth. Introduced with #16453

CC @awarecan

@balloob balloob added this to the 0.78.0 milestone Sep 11, 2018
@homeassistant homeassistant added cla-signed core small-pr PRs with less than 30 lines. labels Sep 11, 2018
@ghost ghost assigned balloob Sep 11, 2018
@ghost ghost added the in progress label Sep 11, 2018
@balloob balloob merged commit 4e3faf6 into dev Sep 11, 2018
@balloob balloob deleted the fix-auth-store branch September 11, 2018 10:55
@ghost ghost removed the in progress label Sep 11, 2018
balloob added a commit that referenced this pull request Sep 11, 2018
@@ -235,7 +235,7 @@ def __init__(self, hass: HomeAssistant) -> None:
continue
token_type = rt_dict.get('token_type')
if token_type is None:
if rt_dict['clinet_id'] is None:
if rt_dict['client_id'] is None:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we use constants for these strings?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe. This is only used for loading/restoring.

@balloob balloob mentioned this pull request Sep 17, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants