Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support for Starling Bank #16522

Merged
merged 6 commits into from
Sep 18, 2018
Merged

Added support for Starling Bank #16522

merged 6 commits into from
Sep 18, 2018

Conversation

dullage
Copy link
Contributor

@dullage dullage commented Sep 9, 2018

Description:

Added support for Starling Bank.

Pull request in home-assistant.github.io with documentation (if applicable): home-assistant/home-assistant.io#6236

Example entry for configuration.yaml (if applicable):

sensor:
  - platform: starlingbank
    accounts:
      - name: "Spending Money"
        sandbox: false
        access_token: YOUR_PERSONAL_ACCESS_TOKEN
        balance_types:
          - 'cleared_balance'
          - 'effective_balance'

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • New dependencies have been added to the REQUIREMENTS variable (example).
  • New dependencies are only imported inside functions that use them (example).
  • New or updated dependencies have been added to requirements_all.txt by running script/gen_requirements_all.py.
  • New files were added to .coveragerc.

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@homeassistant
Copy link
Contributor

Hi @dullage,

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

homeassistant/components/sensor/starlingbank.py Outdated Show resolved Hide resolved
.coveragerc Outdated Show resolved Hide resolved
homeassistant/components/sensor/starlingbank.py Outdated Show resolved Hide resolved
@dullage dullage changed the title Added support for Starling Bank WIP: Added support for Starling Bank Sep 10, 2018
@homeassistant

This comment has been minimized.

@dullage dullage changed the title WIP: Added support for Starling Bank Added support for Starling Bank Sep 11, 2018
@dgomes dgomes removed the cla-error label Sep 14, 2018
@fabaff fabaff merged commit 56b0d2e into home-assistant:dev Sep 18, 2018
@ghost ghost removed the in progress label Sep 18, 2018
})


def setup_platform(hass, config, add_devices, discovery_info=None):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have renamed add_devices to add_entities.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @MartinHjelmare, I think I'm write in saying this is just a cosmetic thing? If so, would it be a good idea for me to wrap this rename up in a bigger change at a later date?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, nothing is broken like this. 👍

But it's nice to keep everything in sync to allow future smooth migrations.

@balloob balloob mentioned this pull request Sep 28, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants