Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Multiple tag managers for Wireless Sensor Tags. #16353

Merged
merged 4 commits into from
Sep 13, 2018
Merged

Multiple tag managers for Wireless Sensor Tags. #16353

merged 4 commits into from
Sep 13, 2018

Conversation

sergeymaysak
Copy link
Contributor

@sergeymaysak sergeymaysak commented Sep 1, 2018 •
edited
Loading

Description:

This PR improves Wireless Sensor Tags platform support and:

  • adds support for multiple tags managers in single user account
  • simplifies further support by moving tags hw specifics into wirelesstagpy library
  • fixes issue with inability to install push notifications when domain name is used
  • includes fixes for typo reported in Wireless Tags - Signal Straight (Strength?) #15695

Related issue (if applicable):
fixes #15695

Checklist:

  • The code change is tested and works locally.
  • Local tests pass with tox. Your PR cannot be merged unless tests pass

If the code does not interact with devices:

  • Tests have been added to verify that the new code works.

@ghost ghost added the in progress label Sep 1, 2018
@sergeymaysak sergeymaysak mentioned this pull request Sep 1, 2018
Closed
@balloob balloob merged commit f63dba5 into home-assistant:dev Sep 13, 2018
@ghost ghost removed the in progress label Sep 13, 2018
@balloob balloob mentioned this pull request Sep 28, 2018
Merged
@sergeymaysak sergeymaysak mentioned this pull request Oct 26, 2018
Closed
@home-assistant home-assistant locked and limited conversation to collaborators Feb 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@balloob balloob balloob approved these changes

Assignees
No one assigned
Labels
cla-signed integration: wirelesstag
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Wireless Tags - Signal Straight (Strength?)
3 participants
@sergeymaysak @balloob @homeassistant