Broadlink service name

[Danielhiversen]

Description:

Should fix #15067, but is not tested.
And no response from the issue opner

[elupus]

Cant you switch it to an entity name instead? IP addresses is often not fixed.

[Danielhiversen]

The correct ip address/hostname needs to be specified for the connection to work

[elupus]

Absolutly, but the service name doesn't need to include this.

[Danielhiversen]

That is correct. But I do not think it is worth a breaking change.

[elupus]

Accepting dns name would mitigate it without a breaking change I suppose.

[pvizeli]

We should not make a service per device. The device or entity_id should be a option and internal inside the handler should be call the correct device. @balloob ?

[Danielhiversen]

Good point.
Might be worth changing to that, even if it will be a breaking change?
(I currently do not have any Broadlink components available, so I do not want to do too much changes that I can not test. And it seems to be hard to find other users willing to test changes here.)

[elupus]

I can test of you do an initial version. PS. Might take a while for me to get round to it though. Den mån 3 sep. 2018 14:56Daniel Høyer Iversen <[email protected]> skrev:

…

Good point. Might be worth changing to that, even if it will be a breaking change? (I currently do not have any Broadlink components available, so I do not want to do too much changes that I can not test. And it seems to be hard to find other users willing to test changes here.) — You are receiving this because you commented. Reply to this email directly, view it on GitHub <#16345 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AAdeoOthtkXpTxnV8GamW1HlTq-aAxSAks5uXSYigaJpZM4WWKh6> .

[balloob]

I agree that this should be moved to a single service, but I think that this fix for now is fine.