The announcement command is incorrect for PT-BR

[cvroque]

The problem

Hello!

I've been having issues with the Google Assistant SDK ignoring some broadcasts when using my native language (pt-BR). Checking google web activity logs it seems that the Assistant fails to understand the commands because they aren't the expected ones.

After some digging I found this line:

"pt": ("Transmite {0}", "Transmite para {1} {0}"), in notify.py

These commands are correct for "pt" as seen here, but incorrect for pt-BR which is described here.

There's some code suggesting that the supported language should be only pt-BR:

SUPPORTED_LANGUAGE_CODES: Final = [... "pt-BR",] in const.py

DEFAULT_LANGUAGE_CODES = {..."pt": "pt-BR",} in helpers.py

The correct translation for these commands would be:

"pt": ("Transmitir {0}", "Transmitir {0} para {1}"),

I've tested this locally and now my broadcasts are working correctly!

Should we just overwrite the pt command with the correct translation (in this case I can make the PR) or we should try to keep both? Thanks in advance!

What version of Home Assistant Core has the issue?

core-2023.4.2

What was the last working version of Home Assistant Core?

No response

What type of installation are you running?

Home Assistant OS

Integration causing the issue

google_assistant_sdk

Link to integration documentation on our website

https://www.home-assistant.io/integrations/google_assistant_sdk/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

[home-assistant]

Hey there @tronikos, mind taking a look at this issue as it has been labeled with an integration (google_assistant_sdk) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of google_assistant_sdk can trigger bot actions by commenting:

• @home-assistant close Closes the issue.
• @home-assistant rename Awesome new title Renames the issue.
• @home-assistant reopen Reopen the issue.
• @home-assistant unassign google_assistant_sdk Removes the current integration label and assignees on the issue, add the integration domain after the command.

_{^{(message by CodeOwnersMention)}}

---

google_assistant_sdk documentation
google_assistant_sdk source
_{^{(message by IssueLinks)}}

[tronikos]

Being fixed in #91293
Thanks!

[cvroque]

Thank you!