Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to Add Roku Television #74712

Closed
lordtaytertot opened this issue Jul 8, 2022 · 7 comments · Fixed by #74862
Closed

Unable to Add Roku Television #74712

lordtaytertot opened this issue Jul 8, 2022 · 7 comments · Fixed by #74862
Assignees

Comments

@lordtaytertot
Copy link

The problem

I own two Roku TVs (a newer, 75" TCL, and an older, 55" Insignia). The Roku integration in Home Assistant can see the 75" TCL just fine, but trying to add the 55" Insignia, I get an "Unexpected error."

What version of Home Assistant Core has the issue?

Home Assistant 2022.7.1

What was the last working version of Home Assistant Core?

Home Assistant 2022.6.x

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Roku

Link to integration documentation on our website

https://www.home-assistant.io/integrations/roku

Diagnostics information

config_entry-roku-0d916486f0ac2ac41c53a61fcea95fab.json.txt

Example YAML snippet

No response

Anything in the logs that might be useful for us?

Logger: homeassistant.components.roku.config_flow
Source: components/roku/config_flow.py:35
Integration: Roku (documentation, issues)
First occurred: 6:41:17 AM (3 occurrences)
Last logged: 6:47:13 AM

Unknown error trying to connect
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/components/roku/config_flow.py", line 73, in async_step_user
    info = await validate_input(self.hass, user_input)
  File "/usr/src/homeassistant/homeassistant/components/roku/config_flow.py", line 35, in validate_input
    device = await roku.update()
  File "/usr/local/lib/python3.10/site-packages/rokuecp/rokuecp.py", line 261, in update
    self._device = Device(updates)
  File "/usr/local/lib/python3.10/site-packages/rokuecp/models.py", line 231, in __init__
    self.update_from_dict(data)
  File "/usr/local/lib/python3.10/site-packages/rokuecp/models.py", line 291, in update_from_dict
    self.apps = [
  File "/usr/local/lib/python3.10/site-packages/rokuecp/models.py", line 292, in <listcomp>
    Application.from_dict(app_data)
  File "/usr/local/lib/python3.10/site-packages/rokuecp/models.py", line 44, in from_dict
    app = data.get("app", data)
AttributeError: 'str' object has no attribute 'get'

Additional information

No response

@probot-home-assistant
Copy link

roku documentation
roku source
(message by IssueLinks)

@probot-home-assistant
Copy link

Hey there @ctalkington, mind taking a look at this issue as it has been labeled with an integration (roku) you are listed as a code owner for? Thanks!
(message by CodeOwnersMention)

@skyegalen
Copy link

skyegalen commented Jul 8, 2022

I began having a similar issue with the integration already installed after updating to 2022.7. Removed integration to attempt recovery and now unable to reinstall.
Getting "unexpected error"
Similar logs as above

Thanks for any input

edit: forgot to mention TCL 55" (55R625)

@ctalkington
Copy link
Contributor

ctalkington commented Jul 10, 2022

@jayjaytay I'd be curious to see the result of:

http://DEVICEIP:8060/query/apps

(try in web browser when device is on)

@ctalkington
Copy link
Contributor

@skyegalen if it's the apps for you too, please try above url in browser as well. Otherwise advise new issue with your error output

@ctalkington
Copy link
Contributor

side note: I believe the root cause is newer xmltodict in recent versions of HA. they changed from OrderedDict to dict and that threw off some parsing from what I'm seeing. hope to have fix in next minor release of HA 2022.7

@skyegalen
Copy link

Thank you for the quick repair!

@github-actions github-actions bot locked and limited conversation to collaborators Aug 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants