Renault entity naming

[sagitt]

The problem

With new Renault integration in 2021.10.X, all entity have a bad naming scheme (respect old custom component)

for example, "sensor.battery_level".

I think is better an entity like sensor.XXXXXX_battery_level, where XXXXXX is for example the integration name, the plate or the VIN number.

What is version of Home Assistant Core has the issue?

core-2021.10.2

What was the last working version of Home Assistant Core?

n/a

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Renault

Link to integration documentation on our website

https://www.home-assistant.io/integrations/renault/

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

[probot-home-assistant]

renault documentation
renault source
_{^{(message by IssueLinks)}}

[probot-home-assistant]

Hey there @epenet, mind taking a look at this issue as it has been labeled with an integration (renault) you are listed as a code owner for? Thanks!
_{^{(message by CodeOwnersMention)}}

[epenet]

Hi @sagitt,
The unique_id of the entities hasn't changed between the old custom component and the core component.
Only the name has changes, and this can be amended manually in the UI.

This was discussed with @frenck on the original PR: #39605 (comment)

[sagitt]

Hi @sagitt,

The unique_id of the entities hasn't changed between the old custom component and the core component.

Only the name has changes, and this can be amended manually in the UI.

This was discussed with @frenck on the original PR: #39605 (comment)

Of course the user can change entities name, but i think is a better choice (like most integrations) change the integration naming scheme.

Personally, i not change any entity name on my installation working on real device name or integration name, and all integrations are ok, except Renault.

I think that the better solution is the ability to give a name to the integration during configuration and associate the given name as prefix to the entities.

Please think about this solution! Thanks

[epenet]

The VIN is good for unique_id, but not so good for the display name. Maybe we could use the vehicle name (eg. Zoe)?
Something like this from tplink:

core/homeassistant/components/tplink/sensor.py

Lines 164 to 170 in 748d915

	@property
	def name(self) -> str:
	"""Return the name of the Smart Plug.
	Overridden to include the description.
	"""
	return f"{self.device.alias} {self.entity_description.name}"

[sagitt]

The VIN is good for unique_id, but not so good for the display name. Maybe we could use the vehicle name (eg. Zoe)?

Something like this from tplink:

core/homeassistant/components/tplink/sensor.py

Lines 164 to 170 in 748d915

	@property
	def name(self) -> str:
	"""Return the name of the Smart Plug.
	Overridden to include the description.
	"""
	return f"{self.device.alias} {self.entity_description.name}"

Car model, VIN, integration name or car plate are all ok

But i think is a bad choice (as now) a generic entity name without prefix like "sensor.battery_level".