-
-
Notifications
You must be signed in to change notification settings - Fork 32.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Google Assistant: Add 2FA to doors, locks #23219
Comments
So we have only one choice, |
We can integrated this with our current MFA module either TOTP or HOTP. The workflow could be
After GA ask user the PIN, user get check preconfigured google authenticator, or received the message contains the pin code, then provide the code to GA. GA then will send the code with intent back to HA, and HA can go through the same logic above to check the if the code is valid. |
I think it maybe a good idea to add 2FA as a general security feature. e.g. if user open front lock from our UI/app, we will ask PIN as well. |
I think that that we don't have to be this complicated. I think that we can just allow users to specify a single pin in their config or UI that is required to interact with security devices. |
single PIN for MVP of course, but eventually I think a general security feature is a good enhancement |
We shouldn't make it too difficult because it will have to be shared with family. |
What is the second factor in the pin challenge mechanism? It sounds like one factor to me. |
User have to link their Google account with HA account or Nabu Casa account as first factor. |
Home Assistant release with the issue: 0.91
Last working Home Assistant release (if known): -
Component/platform: Google Assistant
Description of problem:
Request from Google: Anything that can be a security issue should have 2FA in front of it.
https://developers.google.com/actions/smarthome/two-factor-authentication
Two different 2FA formats: confirm and pin needed.
Devices we should protect:
DEVICE_CLASS_DOOR
,DEVICE_CLASS_GARAGE
The text was updated successfully, but these errors were encountered: