AttributeError: 'ClientConnection' Samsung TV

[Anto79-ops]

The problem

Hello,

Updating to 2024.12.0b0 and my Samsung TV integration seems to broken with the following log thanks

Logger: homeassistant.components.samsungtv
Source: helpers/update_coordinator.py:379
integration: Samsung Smart TV (documentation, issues)
First occurred: 1:26:47 PM (8 occurrences)
Last logged: 1:32:48 PM

Unexpected error fetching samsungtv data
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 379, in _async_refresh
    self.data = await self._async_update_data()
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/samsungtv/coordinator.py", line 45, in _async_update_data
    self.is_on = await self.bridge.async_is_on()
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/samsungtv/bridge.py", line 509, in async_is_on
    return await super().async_is_on()
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/samsungtv/bridge.py", line 422, in async_is_on
    return remote.is_alive()
           ~~~~~~~~~~~~~~~^^
  File "/usr/local/lib/python3.13/site-packages/samsungtvws/async_connection.py", line 177, in is_alive
    return self.connection is not None and not self.connection.closed
                                               ^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'ClientConnection' object has no attribute 'closed'. Did you mean: 'close'?

What version of Home Assistant Core has the issue?

2024.12.0b0

What was the last working version of Home Assistant Core?

2024.11.x

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Samsung TV

Link to integration documentation on our website

https://www.home-assistant.io/integrations/samsungtv/

Diagnostics information

No response

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

No response

[home-assistant]

Hey there @chemelli74, @epenet, mind taking a look at this issue as it has been labeled with an integration (samsungtv) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of samsungtv can trigger bot actions by commenting:

• @home-assistant close Closes the issue.
• @home-assistant rename Awesome new title Renames the issue.
• @home-assistant reopen Reopen the issue.
• @home-assistant unassign samsungtv Removes the current integration label and assignees on the issue, add the integration domain after the command.
• @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
• @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

_{^{(message by CodeOwnersMention)}}

---

samsungtv documentation
samsungtv source
_{^{(message by IssueLinks)}}

[bdraco]

closed is only available in the legacy protocol
https://github.com/python-websockets/websockets/blob/59d4dcf779fe7d2b0302083b072d8b03adce2f61/src/websockets/legacy/protocol.py#L425

[bdraco]

    def is_alive(self) -> bool:
        return self._connection is not None and self._connection.protocol.close_code is None

That should fix it

[bdraco]

https://github.com/xchwarze/samsung-tv-ws-api/blob/8ee4242e3d8b0f873aca5384e75ce39752c773c2/samsungtvws/encrypted/remote.py#L186

[codyc1515]

Also facing this:

Logger: homeassistant.components.samsungtv
Source: helpers/update_coordinator.py:379
integration: Samsung Smart TV (documentation, issues)
First occurred: 10:56:48 (14 occurrences)
Last logged: 11:06:56

Unexpected error fetching samsungtv data
Traceback (most recent call last):
  File "/usr/src/homeassistant/homeassistant/helpers/update_coordinator.py", line 379, in _async_refresh
    self.data = await self._async_update_data()
                ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/samsungtv/coordinator.py", line 45, in _async_update_data
    self.is_on = await self.bridge.async_is_on()
                 ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/samsungtv/bridge.py", line 509, in async_is_on
    return await super().async_is_on()
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/usr/src/homeassistant/homeassistant/components/samsungtv/bridge.py", line 422, in async_is_on
    return remote.is_alive()
           ~~~~~~~~~~~~~~~^^
  File "/usr/local/lib/python3.13/site-packages/samsungtvws/async_connection.py", line 177, in is_alive
    return self.connection is not None and not self.connection.closed
                                               ^^^^^^^^^^^^^^^^^^^^^^
AttributeError: 'ClientConnection' object has no attribute 'closed'. Did you mean: 'close'?

[andreasbrett]

    def is_alive(self) -> bool:
        return self._connection is not None and self._connection.protocol.close_code is None

That should fix it

This will not suffice. See the log in OP's post. It is used in async_connection.py as well. https://github.com/search?q=repo%3Axchwarze%2Fsamsung-tv-ws-api+.closed&type=code

[epenet]

Should be fixed with v2.7.1: #131784