Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

html5 notifications not working under 0.65.4 (or any of the 0.65.x builds) #13165

Closed
enzymes opened this issue Mar 13, 2018 · 8 comments
Closed

Comments

@enzymes
Copy link

enzymes commented Mar 13, 2018

Make sure you are running the latest version of Home Assistant before reporting an issue.

You should only file an issue if you found a bug. Feature and enhancement requests should go in the Feature Requests section of our community forum:

Home Assistant release (hass --version):
0.65.4

Python release (python3 --version):

Python 3.5.3

Component/platform:
notify.html5

Description of problem:

On startup, the overview panel says:

Invalid config. The following components and platforms could not be set up
notify.html5
Please check your config

html5 notifications fail on 65.3 - it said “please set up the html5 platform”

Expected:

Notifications should work. When I rolled back to 64.3 and notifications resume working again. Nothing else I’ve changed

Problem-relevant configuration.yaml entries and steps to reproduce:

Traceback (if applicable):

Additional info:

@OttoWinter
Copy link
Member

This is a config validation issue, so it would be really nice if you could fill out the issue template. Specifically the configuration.yaml section. Without at least the platform: html5 section of your configuration this is much harder to debug :/

@OttoWinter
Copy link
Member

Probably because of #12463; CC @balloob Could you have a quick look at the html5 schema to see if that voluptuous update could have caused the issue? I know too little about voluptuous to debug this (yet). Only if you have time of course.

@dshokouhi
Copy link
Member

I am on 0.65.4 and I do not have this issue.

this is how I have it configured:

 - platform: html5
   name: chrome
   gcm_api_key: !secret gcm_api_key
   gcm_sender_id: !secret gcm_sender_id```

@fanaticDavid
Copy link
Contributor

fanaticDavid commented Mar 13, 2018

#12463 was already included in 0.64, a version that restores the HTML5 notification platform for the OP. Maybe this is caused by #12993?

HTML5 notifications are working just fine for me though, with Home Assistant 0.65.3. In fact, the 0.65.x branch did indeed fix the notifications in Firefox, which were (and still are) working fine in Chrome.

My config:

notify:
  - platform: html5
    name: "html5"
    gcm_api_key: !secret NOTIFY_HTML5_GCM_API_KEY
    gcm_sender_id: !secret NOTIFY_HTML5_GCM_SENDER_ID

@OttoWinter
Copy link
Member

@fanaticDavid This is a configuration validation issue:

Invalid config. The following components and platforms could not be set up

And no commits that I can see (including #12993) have modified any of the html5 platform config validation code. The voluptuous upgrade in #12463 has been known to have caused several of issues like this one. I'd say better just to wait for the configuration section from the OP and then see what's going on.

@enzymes
Copy link
Author

enzymes commented Mar 13, 2018

My configuration.yaml includes:

notify: !include notify.yaml

My notify.yaml

  - platform: html5
    name: html5
    gcm_api_key: !secret gcm_api_key
    gcm_sender_id: !secret gcm_sender_id

Aargh, can't figure out how to format code in github, but it is clean code

@OttoWinter
Copy link
Member

@enzymes You can use code blocks like described here: https://github.com/adam-p/markdown-here/wiki/Markdown-Cheatsheet#code-and-syntax-highlighting; I edited the comment for you :)

Hmmm, I don't know why the configuration would break with 0.65; I myself am using the exact same config. Could maybe something else changed in between, maybe the secrets.yaml doesn't have gcm_api_key or gcm_sender_id or they're empty strings?

Looking at the code I can't see anything that would have changed since that version and I now think this is rather somehow due to your configuration...

@enzymes
Copy link
Author

enzymes commented Mar 20, 2018

Hey after all that, it looks like it was my hassbian installation. I've just wiped it and reinstalled hassbian from a fresh install and re-loaded my config files - everything's working.

Thanks for doing some checking.

@enzymes enzymes closed this as completed Mar 20, 2018
@home-assistant home-assistant locked and limited conversation to collaborators Jul 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants