Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rachio uses async_config_entry_first_refresh warning #130773

Closed
brg468 opened this issue Nov 16, 2024 · 2 comments · Fixed by #130865
Closed

Rachio uses async_config_entry_first_refresh warning #130773

brg468 opened this issue Nov 16, 2024 · 2 comments · Fixed by #130865
Assignees

Comments

@brg468
Copy link
Contributor

brg468 commented Nov 16, 2024

The problem

Detected that integration 'rachio' uses async_config_entry_first_refresh, which is only supported for coordinators with a config entry and will stop working in Home Assistant 2025.11.

This is logged on every start.

What version of Home Assistant Core has the issue?

2024.11.1

What was the last working version of Home Assistant Core?

2024.10.X

What type of installation are you running?

Home Assistant OS

Integration causing the issue

Rachio

Link to integration documentation on our website

https://www.home-assistant.io/integrations/rachio/

Diagnostics information

Detected that integration 'rachio' uses async_config_entry_first_refresh, which is only supported for coordinators with a config entry and will stop working in Home Assistant 2025.11 at homeassistant/components/rachio/init.py, line 96: await base.status_coordinator.async_config_entry_first_refresh(), please create a bug report at https://github.com/home-assistant/core/issues?q=is%3Aopen+is%3Aissue+label%3A%22integration%3A+rachio%22

Example YAML snippet

No response

Anything in the logs that might be useful for us?

No response

Additional information

The coordinators are part of the config entry, so I'm not sure what is supposed to be used here...
Maybe just coordinator.async_refresh()?

I didn't see anything in the dev blog that mentioned this change.

@home-assistant
Copy link

Hey there @bdraco, @rfverbruggen, mind taking a look at this issue as it has been labeled with an integration (rachio) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of rachio can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Renames the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign rachio Removes the current integration label and assignees on the issue, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the issue.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the issue.

(message by CodeOwnersMention)


rachio documentation
rachio source
(message by IssueLinks)

@epenet
Copy link
Contributor

epenet commented Nov 18, 2024

The coordinators are part of the config entry, so I'm not sure what is supposed to be used here...
Maybe just coordinator.async_refresh()?

The coordinator is initialised via hass.async_add_executor_job, so looses context reference to the config entry in

await hass.async_add_executor_job(self._setup, hass)

The link to the config_entry needs to be adjusted to a "hard" link, done in #130865 (should be available in the next patch)

@github-actions github-actions bot locked and limited conversation to collaborators Dec 18, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants